Skip to content

refactor(upload-file-operation): upload file resolver - #17791

Merged
alperozturk96 merged 5 commits into
masterfrom
refactor/upload-file-operation-file-resolver
Oct 12, 2026
Merged

alperozturk96 merged 5 commits into
masterfrom
refactor/upload-file-operation-file-resolver

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

Changes

  • Moves out file conversions related logic outside of the upload file operation thus we can simplify upload file operation step by step

@alperozturk96 alperozturk96 added ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) 3. to review labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 5a86199
Version 17791
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.23944% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ud/android/operations/upload/UploadFileResolver.kt 72.88% 14 Missing and 2 partials ⚠️
...ncloud/android/operations/UploadFileOperation.java 75.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alperozturk96
alperozturk96 force-pushed the refactor/upload-file-operation-file-resolver branch from 333a959 to 181f422 Compare October 9, 2026 06:10
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

@alperozturk96
alperozturk96 force-pushed the refactor/upload-file-operation-file-resolver branch from 181f422 to fe9c716 Compare October 9, 2026 08:30
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 9, 2026
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/upload-file-operation-file-resolver branch from fe9c716 to 29a3ed5 Compare October 12, 2026 10:47
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3030
Correctness5352
Dodgy code177174
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3431
Security1616
Total339332

@alperozturk96
alperozturk96 merged commit 91679d4 into master Oct 12, 2026
23 of 24 checks passed
@alperozturk96
alperozturk96 deleted the refactor/upload-file-operation-file-resolver branch October 12, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants