Skip to content

Add folder actions for folder you are currently in - #17817

Merged
alperozturk96 merged 6 commits into
masterfrom
feat/current-folder-actions
Oct 14, 2026
Merged

alperozturk96 merged 6 commits into
masterfrom
feat/current-folder-actions

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

Partly tackles #2428 by adding the actions which do not require navigating out of the folder.

Action bottom sheet is opened when tapping the 3-dot menu as well as the name of the folder:

  • Add to favorites: Since the state change was not super clear, now the bottom sheet keeps showing for a very short time to reflect the updated state.
  • Details: Fixed that the folder view jumped for a split second as the row with the "Sort by" and grid/list toggle was hidden just before opening this.
  • Send/share: Same here
  • Sync: The icons on the files were only updated on navigating out and back into the folder, fixed that. Also fixed that icons did not vanish immediately on Delete → Local only.
  • Encrypt: If enabled on server

Out of scope for now, but can be done in a follow-up:

  • Rename
  • Move or copy
  • Delete

🖼️ Screenshots

🏚️ Before 🏡 After After with menu open
before-folder after-folder after-sheet

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are not needed
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 9fba721
Version 17817
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@alperozturk96
alperozturk96 force-pushed the feat/current-folder-actions branch from 2db5ffd to ca1cbb3 Compare October 13, 2026 13:02
…for folder download worker can cause issue

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice2525
Correctness5252
Dodgy code164164
Experimental11
Malicious code vulnerability22
Multithreaded correctness2020
Performance3030
Security1616
Total310310

@alperozturk96
alperozturk96 merged commit 0699d5a into master Oct 14, 2026
23 of 24 checks passed
@alperozturk96
alperozturk96 deleted the feat/current-folder-actions branch October 14, 2026 06:58
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Oct 14, 2026
@jancborchardt

Copy link
Copy Markdown
Member Author

@alperozturk96 thanks! :) Regarding this revert commit: 5817dee
Will you add that back later in a follow-up? Cause I do consider it necessary, since if you are in a folder now and choose "Sync" there is no feedback whatsoever.

@alperozturk96

alperozturk96 commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

@alperozturk96 thanks! :) Regarding this revert commit: 5817dee Will you add that back later in a follow-up? Cause I do consider it necessary, since if you are in a folder now and choose "Sync" there is no feedback whatsoever.

This commit will cause a performance problem because FolderDownloadWorker can do Sync and Sync All which means it will download first depth of the folder or entire directory tree of the folder. Using broadcast manager for each file and firing event for each and observing for each is bad approach.

But we can think about better solution via different PR. Now when user presses sync user sees download notification and after folder download completed sees the green tick and I know you want to see green tick one by one. I will try to solve via better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants