Skip to content

Video player: fullscreen now hides system status bar, keep screen on while video is playing #17830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniele-verducci wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

Video player: fullscreen now hides system status bar, keep screen on while video is playing #17830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce5f77
Video/Image player: hide all system bars when going fullscreen instea…
daniele-verducci Oct 16, 2026
bf6a0ce
Keep screen on while video is playing
daniele-verducci Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/com/owncloud/android/ui/preview/PreviewImageActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,9 +670,9 @@ class PreviewImageActivity :
val showBars = !isActionBarVisible
toggleActionBarVisibility(showBars)
if (showBars) {
windowInsetsController.show(WindowInsetsCompat.Type.navigationBars())
windowInsetsController.show(WindowInsetsCompat.Type.systemBars())
} else {
windowInsetsController.hide(WindowInsetsCompat.Type.navigationBars())
windowInsetsController.hide(WindowInsetsCompat.Type.systemBars())
}
}

Expand Down
6 changes: 6 additions & 0 deletions app/src/main/java/com/owncloud/android/ui/preview/PreviewPlaybackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import com.nextcloud.client.player.model.PlayerThumbnailLoader
import com.nextcloud.client.player.model.file.PlaybackCollection
import com.nextcloud.client.player.model.file.PlaybackFile
import com.nextcloud.client.player.model.state.PlaybackState
import com.nextcloud.client.player.model.state.PlayerState
import com.nextcloud.client.player.model.state.VideoSize
import com.nextcloud.client.player.ui.MediaNavigator
import com.nextcloud.client.player.util.PlayerUtil.applyVideoSize
Expand Down Expand Up @@ -370,6 +371,11 @@ class PreviewPlaybackFragment :
if (isCurrentItem(state)) {
wasCurrentItem = true
showVideo(state?.currentItemState?.videoSize)

// Keep the screen on while playing. This works because it's called at every playback update and when
// the surfaceview is not visible (scrolled away, app in background...)
binding.surfaceView.keepScreenOn = state?.currentItemState?.playerState == PlayerState.PLAYING

return
}

Expand Down
Loading