Skip to content

refactor: convert store to factory functions - #7383

Merged
juliusknorr merged 2 commits into
mainfrom
refactor-store-to-factory-functions
Nov 25, 2025
Merged

juliusknorr merged 2 commits into
mainfrom
refactor-store-to-factory-functions

Conversation

@luka-nextcloud

@luka-nextcloud luka-nextcloud commented Nov 20, 2025 •

Copy link
Copy Markdown
Contributor

Summary

Refactors the Vuex store setup to use factory functions for creating new store instances. This change allows Board reference widgets to maintain separate store instances, resolving the issue where loading multiple board widgets would always load the same board.

Store architecture refactor:

  • Changed store/main.js to export a storeFactory function that returns a new Vuex store instance, instead of exporting a singleton store. All imports and usages of the store are updated to use storeFactory().

  • Refactored store/stack.js and store/card.js to export factory functions (stackModuleFactory, cardModuleFactory) that return new module objects, replacing singleton module exports.

Widget and component store usage:

  • Updated components and widgets (e.g., BoardReferenceWidget.vue, widget registration in init-reference.js) to use new store instances by calling storeFactory()

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Comment thread src/sessions.js Outdated
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud
luka-nextcloud force-pushed the refactor-store-to-factory-functions branch from a44c563 to b6d0540 Compare November 24, 2025 18:37
@juliusknorr
juliusknorr merged commit 535c02f into main Nov 25, 2025
34 checks passed
@juliusknorr
juliusknorr deleted the refactor-store-to-factory-functions branch November 25, 2025 19:16
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable32

@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable31

@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable30

@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple embed board widgets only show same board

2 participants