Skip to content

chore: update sharing status icon - #8498

Open
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:sharing_status
Open

madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:sharing_status

Conversation

@madbob

@madbob madbob commented Oct 5, 2026

Copy link
Copy Markdown
  • Target version: main

Summary

Right now, sharing and unsharing a board doesn't provide immediate feedback on boards' list.

This change permit to display and hide the sharing status icon as the board itself is shared/unshared from Details panel.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check whether any of these happen?

  • Opening a board drops it from "Shared with you"
  • The previous board stays shown while loading, or after a failed load
    (result of removing this.setCurrentBoard(null) this should be kept).
  • Also the sort change may have side effects, and does not seem relevant either?

Signed-off-by: Roberto Guido <info@madbob.org>
@madbob

madbob commented Oct 25, 2026

Copy link
Copy Markdown
Author

this.setCurrentBoard(null) resets the current board, generating an unpleasant effect on the screen (which is reloaded from scratch).

Test---Deck---Nextcloud.mp4

Indeed, I've wrapped the code in a try/catch block to handle loading failures.

To be honest, I've tested again the change in the sorting of boards and seems it had no effect. So I've reverted again that modification, probably it was an harmless (and useless) try while investigating around the issue.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants