Repository navigation
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
blizzz
left a comment
There was a problem hiding this comment.
Can you double check whether any of these happen?
- Opening a board drops it from "Shared with you"
- The previous board stays shown while loading, or after a failed load
(result of removingthis.setCurrentBoard(null)this should be kept). - Also the sort change may have side effects, and does not seem relevant either?
Signed-off-by: Roberto Guido <info@madbob.org>
8a291b9 to
2991ba8
Compare
|
Test---Deck---Nextcloud.mp4Indeed, I've wrapped the code in a try/catch block to handle loading failures. To be honest, I've tested again the change in the sorting of boards and seems it had no effect. So I've reverted again that modification, probably it was an harmless (and useless) try while investigating around the issue. |
Summary
Right now, sharing and unsharing a board doesn't provide immediate feedback on boards' list.
This change permit to display and hide the sharing status icon as the board itself is shared/unshared from Details panel.
Checklist