Skip to content

fix(dnd): lists can't be reordered when dropped over another list's cards #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solyin-enof wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

fix(dnd): lists can't be reordered when dropped over another list's cards #8626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2fbe09
fix(dnd): stop card lists from accepting dragged lists
solyin-enof Oct 27, 2026
54944a9
fix: replace removed OC.Notification with @nextcloud/dialogs
solyin-enof Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/board/Stack.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
nonDragAreaSelector=".dragDisabled"
:dragHandleSelector="dragHandleSelector"
data-dragscroll-enabled
:shouldAcceptDrop="() => canEdit"
:shouldAcceptDrop="(sourceOptions) => canEdit && sourceOptions.groupName === 'stack'"
@dragStart="draggingCard = true"
@dragEnd="draggingCard = false"
@drop="($event) => onDropCard(stack.id, $event)">
Expand Down
2 changes: 1 addition & 1 deletion src/components/navigation/AppNavigationBoard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ export default {
this.$router.push({ name: 'board', params: { id: newBoard.id } })
} catch (e) {
logger.error('Failed to clone board', { error: e })
OC.Notification.showTemporary(t('deck', 'An error occurred'))
showError(t('deck', 'An error occurred'))
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion src/services/SharingApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/

import axios from '@nextcloud/axios'
import { showError } from '@nextcloud/dialogs'
import { generateOcsUrl } from '@nextcloud/router'
import logger from '../logger.js'

Expand All @@ -18,7 +19,7 @@ async function createShare({ path, permissions, shareType, shareWith, publicUplo
return request
} catch (error) {
logger.error('Error while creating share', { error })
OC.Notification.showTemporary(t('files_sharing', 'Error creating the share'), { type: 'error' })
showError(t('files_sharing', 'Error creating the share'))
throw error
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/stores/stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { showError } from '@nextcloud/dialogs'
import { defineStore } from 'pinia'
import applyOrderToArray from '../helpers/applyOrderToArray.js'
import logger from '../logger.js'
Expand Down Expand Up @@ -42,7 +43,7 @@ export const useStackStore = defineStore('stack', {
}
apiClient.reorderStack(stack.id, addedIndex, stack.boardId)
.catch((err) => {
OC.Notification.showTemporary('Failed to change order')
showError('Failed to change order')
logger.error('Failed to reorder stack', { error: err })

// restore old order
Expand Down