Backport/10680/stable 34.0 - #10725
Merged
Merged
Conversation
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
September 2, 2026 16:20
claucambra
approved these changes
Sep 3, 2026
Application::configVersionMigration() clears the Updater/* keys on the first start of a newly installed version, before NSISUpdater::handleStartup() gets a chance to see them and clean up the downloaded installer. The installer and msi.log are then orphaned in the config folder with nothing left to find them by, repeating on every update. ConfigFile::cleanUpdaterConfiguration() now deletes the installer and msi.log before dropping the keys, so both the migration path and the updater's own cleanup remove the file. NSISUpdater::wipeUpdateData() delegates to it instead of duplicating the removal logic. Reported by @tgebler as still reproducing after #8980: #8980 (comment) Closes #7009. Assisted-by: ClaudeCode:claude-sonnet-5 Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr> Signed-off-by: chrip <christoph.schaefer@nextcloud.com>
mgallien
force-pushed
the
backport/10680/stable-34.0
branch
from
September 3, 2026 07:24
2ce6c83 to
dcc3d4b
Compare
mgallien
enabled auto-merge
September 3, 2026 07:25
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10725.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #10680
Resolves
#
Summary
TODO
Checklist
AI (if applicable)