Skip to content

fix: do not add result permissions to see own submissions - #3128

Merged
susnux merged 1 commit into
mainfrom
fix/perms
Jan 22, 2026
Merged

susnux merged 1 commit into
mainfrom
fix/perms

Conversation

@susnux

@susnux susnux commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

When a user has submitted a form they should not have result permissions, but instead we should only show their own submissions.

@susnux
susnux requested a review from Chartman123 January 22, 2026 17:47
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jan 22, 2026
@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable5.2

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jan 22, 2026
@Chartman123

Copy link
Copy Markdown
Collaborator

Just checked it, seems to fully fix the issue :) Thanks!

@Chartman123 Chartman123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the failing tests :)

When a user has submitted a form they should not have result
permissions, but instead we should only show their own submissions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator Author

Looks good, just the failing tests :)

Randomly worked before as the parameters were passed positional but in the meantime we added new parameters 🙈
fixed ✅

@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@susnux
susnux merged commit b8cf7be into main Jan 22, 2026
56 checks passed
@susnux
susnux deleted the fix/perms branch January 22, 2026 22:56
@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Answers are visible although no view right is shared

2 participants