Repository navigation
fix: Prevent infinity loop on form deletion - #3343
Merged
Merged
Conversation
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/fix-form-deletion
branch
from
May 16, 2026 22:27
16e6c19 to
b106d61
Compare
Collaborator
|
Strange, this was already fixed some time ago iirc. And I deleted a form on my dev instance without this fix and couldn't see the loading loop. Are you sure that you're on current main? |
Collaborator
|
Ok, I deleted another form right now and hit the loop... |
Chartman123
approved these changes
May 18, 2026
Chartman123
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer:
Actual result: form has been deleted but we have some kind of the infinity loop and tons of errors.
This PR aims to fix that