Skip to content

feat(sharing): Allow custom share tokens for public links - #3435

Merged
Chartman123 merged 1 commit into
mainfrom
feature/custom-share-links
Jul 2, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
feature/custom-share-links

Conversation

@Chartman123

@Chartman123 Chartman123 commented Jun 19, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #2815

This adds admin-gated custom tokens for public Forms share links. By default the feature is disabled, so existing instances keep the current random-token behavior. When enabled by an admin, form owners can edit the token of an existing public link directly in the sharing sidebar, save it explicitly, and the old URL becomes invalid immediately.

It also adds the necessary backend support for token updates, keeps public-link routing compatible with custom tokens, and includes tests plus API documentation updates.

New PR replacing #3311

Tasks still missing:

@Chartman123
Chartman123 force-pushed the feature/custom-share-links branch 3 times, most recently from 2926055 to da647a3 Compare June 19, 2026 20:35
@codecov

codecov Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Controller/ShareApiController.php 77.55% 11 Missing ⚠️
lib/Controller/PageController.php 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 force-pushed the feature/custom-share-links branch from 8af7d26 to 5d6e136 Compare June 19, 2026 23:53
@Chartman123 Chartman123 self-assigned this Jun 19, 2026
@Chartman123 Chartman123 added enhancement New feature or request 3. to review Waiting for reviews feature: 👥 sharing settings labels Jun 19, 2026
@Chartman123 Chartman123 added this to the 5.4 milestone Jun 19, 2026
@Chartman123
Chartman123 marked this pull request as ready for review June 19, 2026 23:58
@Chartman123
Chartman123 marked this pull request as draft June 26, 2026 07:20
@Chartman123
Chartman123 force-pushed the feature/custom-share-links branch 2 times, most recently from 3d45f45 to 5a6d9c6 Compare June 28, 2026 23:14
Signed-off-by: Alexander Rebello <me@alexander-rebello.de>
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Chartman123 force-pushed the feature/custom-share-links branch from 5a6d9c6 to 66f57a5 Compare June 28, 2026 23:19
@Chartman123
Chartman123 marked this pull request as ready for review June 28, 2026 23:22
@Chartman123

Copy link
Copy Markdown
Collaborator Author

@susnux @pringelmann this should now be ready for review :) Please check if I added the BruteForceProtection correctly :)

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pulling this through to the end :)

@Chartman123
Chartman123 merged commit 26c11aa into main Jul 2, 2026
54 checks passed
@Chartman123
Chartman123 deleted the feature/custom-share-links branch July 2, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: 👥 sharing settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readable links when sharing

3 participants