Skip to content

fix: improve user validation on file question type - #3492

Merged
Chartman123 merged 1 commit into
mainfrom
fix/1854-missing-formid-uploadedfileid
Jul 15, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/1854-missing-formid-uploadedfileid

Conversation

@samin-z

@samin-z samin-z commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

when submitting the form where question type if file, check with token and question id if the same user who uploaded the file is submitting it.

@samin-z
samin-z requested review from Chartman123 and Koc and removed request for Koc July 14, 2026 14:50

@Chartman123 Chartman123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one little comment: please also update the documentation in https://github.com/nextcloud/forms/blob/main/docs/API_v3.md#upload-a-file

@Chartman123

Copy link
Copy Markdown
Collaborator

/backport to stable5.3

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jul 14, 2026
@samin-z

samin-z commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

thank you @Chartman123
ill fix the pipelines and then update the documentation

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
samin-z force-pushed the fix/1854-missing-formid-uploadedfileid branch from 8883a0c to 3b5a4b2 Compare July 15, 2026 10:08
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Migration/Version050300Date20260713180000.php 0.00% 18 Missing ⚠️
lib/Db/UploadedFileMapper.php 0.00% 13 Missing ⚠️
lib/Db/UploadedFile.php 66.66% 1 Missing ⚠️
lib/Service/SubmissionService.php 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit 9014225 into main Jul 15, 2026
52 of 53 checks passed
@Chartman123
Chartman123 deleted the fix/1854-missing-formid-uploadedfileid branch July 15, 2026 12:35
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: 📝 submitting responses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants