Repository navigation
fix: remove invalid characters constant and use filename validator for sanitization - #3494
Merged
Merged
Conversation
Chartman123
added
bug
Collaborator
Author
|
/backport to stable5.3 |
Chartman123
assigned
Chartman123 and unassigned
Koc,
susnux,
pringelmann,
Chartman123 and
samin-z
Koc
approved these changes
Jul 14, 2026
Koc
left a comment
Koc
left a comment
Collaborator
There was a problem hiding this comment.
It seems like tests require adjustment
Chartman123
force-pushed
the
fix/upload-files-with-windows-compatibility
branch
2 times, most recently
from
July 14, 2026 22:29
63ee717 to
1b1e73d
Compare
Collaborator
Author
They're taking like forever to run today... 🙈 |
Chartman123
force-pushed
the
fix/upload-files-with-windows-compatibility
branch
from
July 15, 2026 06:45
1b1e73d to
597d70e
Compare
…r sanitization Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: GitHub <noreply@github.com>
Chartman123
force-pushed
the
fix/upload-files-with-windows-compatibility
branch
from
July 15, 2026 07:14
597d70e to
71d77d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3458. Now that we're at min version 32, we can use
sanitizeFilename()fromOCP\Files\IFilenameValidatorto cleanup the names of uploaded files.