Repository navigation
[stable5.3] fix(api): correct misleading error message on empty keyValuePairs - #3502
Merged
Merged
Conversation
updateQuestion() rejected an empty keyValuePairs array with the message "This form is archived and can not be modified". That message is unrelated to the actual cause and sends callers looking in the wrong place. The sibling methods updateForm() and updateOption() already report this case accurately, and updateQuestion()'s own @throws annotation documents it as "Empty keyValuePairs, will not update" too, so the string looks like a copy-paste leftover from the archived-form check further up. Only the message is changed. The exception type stays OCSBadRequestException so the HTTP status code is unaffected. Signed-off-by: Josef Behr <code@josef-behr.de> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Chartman123
approved these changes
Jul 16, 2026
Chartman123
enabled auto-merge
July 16, 2026 07:02
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #3500