Skip to content

fix: results route handling in dev mode - #3547

Merged
Chartman123 merged 1 commit into
mainfrom
fix/results-view
Aug 5, 2026
Merged

fix: results route handling in dev mode#3547
Chartman123 merged 1 commit into
mainfrom
fix/results-view

Conversation

@Chartman123

Copy link
Copy Markdown
Collaborator

This fixes a regression introduced in #3432. When you reloaded a results page with F5 or directly called a subview when the app was running with npm run dev, the results view got duplicated over and over into the router-view.

As a fix/refactoring I moved the routes from url params to direct child routes defined in router.ts.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Chartman123 Chartman123 added this to the 5.4 milestone Jul 30, 2026
@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels Jul 30, 2026
@Chartman123
Chartman123 requested a review from Koc July 30, 2026 20:14
@Chartman123 Chartman123 added regression Regression of a previous working feature feature: 📊 responses & statistics labels Jul 30, 2026
@Chartman123
Chartman123 requested a review from pringelmann July 30, 2026 20:14
@Chartman123 Chartman123 self-assigned this Jul 30, 2026
@Chartman123
Chartman123 requested review from samin-z and susnux July 30, 2026 20:14
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Controller/PageController.php 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 force-pushed the fix/results-view branch 4 times, most recently from aec2cfc to a4a5f3a Compare August 2, 2026 15:59
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Chartman123 merged commit c26d02f into main Aug 5, 2026
52 of 54 checks passed
@Chartman123
Chartman123 deleted the fix/results-view branch August 5, 2026 12:57
@pringelmann

Copy link
Copy Markdown
Collaborator

@Chartman123 sorry I was meaning to do a review this morning. I found a bug where switching to different result views contains stale data:

image Two things here, both needed:
  1. props: { default: true } is on the parent record, which has no components, so it never applies. Move it to both children or the hash prop stays empty forever.
  2. The hash watcher only calls fetchFullForm() now. It used to hit loadFormResults() through syncActiveResponseViewFromRoute(). Add it back, the comment above it still says "Reload results when form changes".

Unrelated: the view only gets saved to localStorage from the $route.name watcher, which doesn't fire on mount, so a reloaded /results/responses isn't remembered. Saving in beforeMount fixes it, but that flips your new redirect test to /results/responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: 📊 responses & statistics regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants