feat(nginx): lower client_max_body_size#861
Open
RisingOpsNinja wants to merge 2 commits into
Open
Conversation
Signed-off-by: RisingOpsNinja <175097282+RisingOpsNinja@users.noreply.github.com>
Signed-off-by: RisingOpsNinja <175097282+RisingOpsNinja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This change lowers the Nginx configuration client_max_body_size to match the default PHP_UPLOAD_LIMIT of 512 MiB in the php-fpm docker image and also match the default nginx configuration in the Nextcloud admin manual after enabling
fastcgi_request_buffering#855Benefits
Lowering the configuration will reduces memory, disk pressure and also lowers risk of resource exhaustion.
client_max_body_sizeis set to 10 GiB which is an exceptionally large default value.Possible drawbacks
Some clients may not support chunked uploads and send the whole file in a single request. Nginx will reject the request if it is larger then
client_max_boy_size.Checklist
Chart.yamlaccording to semver.