Skip to content

[stable5.6] fix(ColorPicker): Use v-model for color picker instead of :value #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Jan 13, 2026
Merged

[stable5.6] fix(ColorPicker): Use v-model for color picker instead of :value #12232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/components/TagItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
</NcActionButton>
<NcColorPicker
v-if="!renameTagLabel"
v-model="editColor"
class="app-navigation-entry-bullet-wrapper"
:value="`#${tag.color}`"
@input="updateColor">
<div :style="{ backgroundColor: tag.color }" class="color0 app-navigation-entry-bullet" />
@submit="updateColor">
<div :style="{ backgroundColor: editColor }" class="color0 app-navigation-entry-bullet" />
</NcColorPicker>
<ActionInput
v-if="renameTagInput"
Expand Down Expand Up @@ -101,6 +101,7 @@ export default {
return {
isAdded: false,
editing: false,
editColor: null,
tagLabel: true,
tagInput: false,
showSaving: false,
Expand All @@ -119,14 +120,13 @@ export default {
this.$emit('delete-tag', this.tag)
},

async updateColor(newColor) {
this.editColor = newColor
async updateColor() {
this.showSaving = false
try {
await this.mainStore.updateTag({
tag: this.tag,
displayName: this.tag.displayName,
color: newColor,
color: this.editColor,
})
this.showSaving = false
} catch (error) {
Expand All @@ -140,6 +140,7 @@ export default {
this.renameTagLabel = false
this.renameTagInput = true
this.showSaving = false
this.editColor = this.tag.color
},

async renameTag(tag, event) {
Expand All @@ -151,7 +152,7 @@ export default {
await this.mainStore.updateTag({
tag,
displayName,
color: tag.color,
color: this.tag.color,
})
this.renameTagLabel = true
this.renameTagInput = false
Expand Down
Loading