Upgrade from Vue 2 to Vue 3 - #1953
Merged
Merged
Conversation
mejo-
approved these changes
Jul 23, 2026
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
I reviewed all comments and they look good to me. Really nice work ❤️
One nitpicking comment: "chore(pinia): pinianize app, notes and sync stores" seems to be an empty commit and can probably be dropped?
silverkszlo
force-pushed
the
chore/upgrade-from-vue2-to-vue3
branch
from
July 23, 2026 08:46
2ac9291 to
6ff3ceb
Compare
enjeck
reviewed
Jul 26, 2026
silverkszlo
force-pushed
the
chore/upgrade-from-vue2-to-vue3
branch
from
July 27, 2026 14:03
6ff3ceb to
981ce5c
Compare
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de>
…odelValue Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
…onObserver Since vue-observe-visibility is only compatible with Vue 2. Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Vue would internally convert 'onChooseSolution' to 'onOnChooseSolution' Signed-off-by: silver <s.szmajduch@posteo.de>
silverkszlo
force-pushed
the
chore/upgrade-from-vue2-to-vue3
branch
from
July 28, 2026 07:09
981ce5c to
aa9afea
Compare
max-nextcloud
approved these changes
Jul 28, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Contributor
There was a problem hiding this comment.
Just checked the two last commits as they had not been reviewed.
Approving with one minor comment
Signed-off-by: silver <s.szmajduch@posteo.de>
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI