Repository navigation
feat: let scoped app passwords read notifications and register for push - #3510
Draft
pringelmann wants to merge 3 commits into
Draft
pringelmann wants to merge 3 commits into
pringelmann wants to merge 3 commits into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Member
Web push is used by mobile apps that don't use google play services. So should also be allowed |
… settings Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Author
Makes sense thanks, I didn’t know web push was used by apps 👍 Opened both web push and the personal settings route. |
nickvergessen
approved these changes
Oct 22, 2026
artonge
approved these changes
Oct 22, 2026
Signed-off-by: Joas Schilling <coding@schilljs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of nextcloud/server#65523
Note
Needs nextcloud/server#65340, which refuses app passwords limited to scopes on every route without a
#[TokenScope]. Until that is merged,nextcloud/ocpdoesn't have the attribute class, so psalm will complain.This stays in
Draftuntil then.Summary
Adds the
notifications:notifications:readscope to the notifications list, push registration (mobile and web push) and your own notification settings.Dismissing a notification and changing your own settings are also open under this scope. Both only touch your own account, so a separate write scope didn't seem worth an extra checkbox. Happy to be convinced otherwise.
Admin settings stay closed.
Manually tested:
The checkbox in Settings follows in server once this is merged.
AI