Basic auth requests always set up the filesystem

ToDo

remove support for old chunking v1 in Desktop

If a request is authenticated and does not use cookies, it will always set up the filesystem.
The reason is the post-login gc we do:

server/lib/base.php

Lines 815 to 831 in e6d9ef2

    
           try { 
        
           	$cache = new \OC\Cache\File(); 
        
           	$cache->gc(); 
        
           } catch (\OC\ServerNotAvailableException $e) { 
        
           	// not a GC exception, pass it on 
        
           	throw $e; 
        
           } catch (\OC\ForbiddenException $e) { 
        
           	// filesystem blocked for this request, ignore 
        
           } catch (\Exception $e) { 
        
           	// a GC exception should not prevent users from using OC, 
        
           	// so log the exception 
        
           	\OC::$server->getLogger()->logException($e, [ 
        
           		'message' => 'Exception when running cache gc.', 
        
           		'level' => ILogger::WARN, 
        
           		'app' => 'core', 
        
           	]); 
        
           }

I think it is time to move that to a proper cron job instead. It would potentially clean up chunked upload attempts but there is no need to do this with every successful login?!

I think chunked upload cleanup already has a cron job: #30772

@tobiasKaminsky

This seems to only cleanup parts from the very old chunking https://github.com/owncloud/core/wiki/spec%3A-big-file-chunking, mabye something we can get rid of then.

@tobiasKaminsky can maybe check if that is still used in any way in the clients as I found at least a code occurence for desktop: https://github.com/nextcloud/desktop/blob/4135b757b9599f95376a416761ad5cf3116411a9/src/libsync/propagateuploadv1.cpp#L115 but I'd think everything is using the new chunked upload anyways

Other than that there seems to be no usage of the \OC\Cache\File class which contains the garbage collection

@mgallien

Discussed with @mgallien we will remove support with 3.7 and announce this in release notes.
As we have our chunked uploading mechanism this is is a decent replacement.

Is this being used as a fallback only? Would it be a problem for older clients of we drop the support in server e.g. for 26?

Is this being used as a fallback only? Would it be a problem for older clients of we drop the support in server e.g. for 26?

the new chunking algorithm has been released with 2.3.0 desktop client release from Mar 3, 2017
I think it is safe to assume clients have upgraded or we can ask them to upgrade

I mean that it should be safe to remove this deprecated code in the 26 server release

@mgallien

@mgallien once you have removed it in Desktop, please link it here, so that we have this for reference :)

We can bump

server/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

Line 67 in f7be761

    
           $minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0');

to be sure

We can bump

server/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

Line 67 in f7be761

$minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0');

to be sure

see #35425
I did it directly

Another usage is any class that injects ICache:

server/lib/private/Server.php

Lines 706 to 710 in 7c4ceb4

    
           $this->registerService(ICache::class, function ($c) { 
        
           	return new Cache\File(); 
        
           }); 
        
           /** @deprecated 19.0.0 */ 
        
           $this->registerDeprecatedAlias('UserCache', ICache::class);

Might be harder to find all cases, but maybe we can actually switch this to a ArrayCache or local memory cache instance instead.

The PR was merged with red CI and had to be reverted, so now it's #53920.

Next try:

#54803
nextcloud/guests#1400

Navigation Menu

Repository navigation

Basic auth requests always set up the filesystem #31357

11 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	try {
	$cache = new \OC\Cache\File();
	$cache->gc();
	} catch (\OC\ServerNotAvailableException $e) {
	// not a GC exception, pass it on
	throw $e;
	} catch (\OC\ForbiddenException $e) {
	// filesystem blocked for this request, ignore
	} catch (\Exception $e) {
	// a GC exception should not prevent users from using OC,
	// so log the exception
	\OC::$server->getLogger()->logException($e, [
	'message' => 'Exception when running cache gc.',
	'level' => ILogger::WARN,
	'app' => 'core',
	]);
	}

	$this->registerService(ICache::class, function ($c) {
	return new Cache\File();
	});
	/** @deprecated 19.0.0 */
	$this->registerDeprecatedAlias('UserCache', ICache::class);

Basic auth requests always set up the filesystem #31357

Description

Activity

PVince81 commented on Aug 15, 2022

juliusknorr commented on Nov 18, 2022

juliusknorr commented on Nov 18, 2022

tobiasKaminsky commented on Nov 23, 2022

juliusknorr commented on Nov 23, 2022

mgallien commented on Nov 24, 2022

tobiasKaminsky commented on Nov 25, 2022

nickvergessen commented on Nov 25, 2022

mgallien commented on Nov 25, 2022

juliusknorr commented on Dec 5, 2022

11 remaining items

provokateurin commented on Jul 14, 2025

provokateurin commented on Sep 2, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions