feat(deps): Upgrade phpseclib to v3#48183
Open
susnux wants to merge 5 commits into
Open
Conversation
susnux
force-pushed
the
fix/deps/php-seclin
branch
3 times, most recently
from
November 5, 2024 22:46
c66f090 to
9ca9c89
Compare
Contributor
Author
|
Problem with this: |
8 tasks
This was
linked to
issues
Jul 8, 2025
8 tasks
joshtrichards
added
bug
2. developing
Member
|
Perhaps |
terrafrost
reviewed
Jan 15, 2026
susnux
force-pushed
the
fix/deps/php-seclin
branch
from
July 19, 2026 20:24
69e115c to
0bee9d3
Compare
susnux
force-pushed
the
fix/deps/php-seclin
branch
6 times, most recently
from
July 19, 2026 21:44
5373ef7 to
3983f8a
Compare
susnux
added
4. to release
susnux
marked this pull request as ready for review
July 20, 2026 09:37
susnux
requested review from
icewind1991,
joshtrichards,
nfebe and
sorbaugh
and removed request for
a team
July 20, 2026 09:37
susnux
commented
Jul 20, 2026
Contributor
Author
There was a problem hiding this comment.
Any options on this solution?
Should we keep the "performance" streams with reflection or drop them completely and just use the library streams?
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Updated RSA key loading to use PSS padding and options. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The implementation was using private fields of v2, which are now properly marked as private. So either drop the custom streams or use reflection. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/deps/php-seclin
branch
from
July 20, 2026 14:05
3983f8a to
8b24535
Compare
nickvergessen
added
the
pending documentation
Member
|
Should document this change, as it breaks at least 2 shipped apps (app_api, nextcloud_announcements) by removing phpseclib 2, and integration_discourse because it ships phpseclib 3 without mozart/namespacing it |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated to v3 - needed to adjust quiet some places.
AI was just used for 3983f8a to help finding a working alternative because the old implementation was using v2 private functions which were not PHP private but just prefixed with
_.In v3 they made them really private so we have two options:
Checklist