refactor(AppFramekwork): Clarify SecurityMiddleware security checks#62322
Draft
joshtrichards wants to merge 7 commits into
Draft
refactor(AppFramekwork): Clarify SecurityMiddleware security checks#62322joshtrichards wants to merge 7 commits into
joshtrichards wants to merge 7 commits into
Conversation
- Move metadata into clear predicates for cleaner authorization, cookie, and CSRF checks. - Document compatibility behavior and policy rationale. - Clean up outdated comments. - Crucial: Retain original validation order to ensure error exceptions remain identical. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Align / make more consistent Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
SecurityMiddleware::beforeController()to make its security policy easier to follow without changing the established check order.Notes
The Bearer authorization-scheme check is now case-insensitive, consistent with HTTP authentication-scheme matching.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)