Skip to content

test(files): make watcher propagation mtime regression test deterministic #62329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −9
Open

test(files): make watcher propagation mtime regression test deterministic #62329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5089955
test(files): make watcher propagation regression test deterministic
joshtrichards Jul 19, 2026
db62803
chore(view): update ViewTest for php-cs/rector
joshtrichards Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions tests/lib/Files/ViewTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,22 +473,32 @@ public function testWatcherDoesNotPropagateWhenStorageMtimeUnchanged(): void {

$rootView = new View('');

// Note the root mtime right after the initial scan.
$rootMtimeBefore = $storage->getCache()->get('')['mtime'];
// Use an mtime that cannot accidentally equal the current timestamp. This makes
// the test fail reliably if propagateChange() is called during this request.
$rootEntry = $storage->getCache()->get('');
$storage->getCache()->update($rootEntry->getId(), [
'mtime' => 1,
'etag' => 'unchanged-root-etag',
]);

// Access a subfolder. The watcher will fire (hasUpdated always returns true),
// but the scanner leaves the cached metadata for 'folder' unchanged.
// getCacheEntry must therefore NOT call propagateChange('folder', time()),
// which would update the root entry's mtime to the current timestamp.
// which would update the root entry's mtime and etag.
$rootView->getFileInfo('folder');

// Read the root mtime directly from the cache to avoid triggering another watcher cycle.
$rootMtimeAfter = $storage->getCache()->get('')['mtime'];
// Read the root entry directly from the cache to avoid triggering another watcher cycle.
$rootEntryAfter = $storage->getCache()->get('');

$this->assertEquals(
$rootMtimeBefore,
$rootMtimeAfter,
'Root folder mtime must not be updated when the watcher fires but cached metadata has not changed'
$this->assertSame(
1,
$rootEntryAfter->getMTime(),
'Root folder mtime must not change when the watcher finds no metadata change',
);
$this->assertSame(
'unchanged-root-etag',
$rootEntryAfter->getEtag(),
'Root folder etag must not change when the watcher finds no metadata change',
);
}

Expand Down
Loading