Repository navigation
fix(files_sharing): Make sure mount events are dispatched for share recipients - #64715
Open
marcelklehr wants to merge 6 commits into
Open
marcelklehr wants to merge 6 commits into
marcelklehr wants to merge 6 commits into
Conversation
marcelklehr
added
3. to review
Open
1 task done
provokateurin
previously requested changes
Sep 24, 2026
marcelklehr
force-pushed
the
test/share-mount-events
branch
from
September 30, 2026 08:38
b1b9455 to
f542914
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable35 |
marcelklehr
marked this pull request as ready for review
September 30, 2026 12:47
marcelklehr
requested review from
Altahrim,
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
September 30, 2026 12:47
marcelklehr
changed the title
marcelklehr
changed the title
come-nc
removed their request for review
October 5, 2026 10:04
marcelklehr
force-pushed
the
test/share-mount-events
branch
from
October 19, 2026 06:45
1fab2bc to
3db8e5f
Compare
susnux
approved these changes
Oct 21, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but a second review of @salmart-dev or @icewind1991 would be good!
salmart-dev
requested changes
Oct 21, 2026
salmart-dev
left a comment
salmart-dev
left a comment
Contributor
There was a problem hiding this comment.
Please add test assertions that cover that the lazy-loaded data is present if you keep the new class.
| $this->share($shareType, self::FOLDER, self::TEST_FILES_SHARING_API_USER1, $recipient, Constants::PERMISSION_ALL); | ||
| $this->getUserFolder(self::TEST_FILES_SHARING_API_USER2)->get(self::FOLDER); | ||
|
|
||
| $this->assertContains( |
Contributor
There was a problem hiding this comment.
fix: this lets duplicate events go unnoticed, the exact amount of expected events should be checked
Member
There was a problem hiding this comment.
imo having duplicate events is fine.
…pients Apps keep per-user data in sync with file access by listening to UserMountAddedEvent and UserMountRemovedEvent. When a share is created or deleted, these events should reach the recipient at the latest when the recipient next sets up their file system. Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
icewind1991
force-pushed
the
test/share-mount-events
branch
4 times, most recently
from
October 23, 2026 14:05
3452131 to
07be8cd
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
test/share-mount-events
branch
from
October 23, 2026 14:08
07be8cd to
8c8b57c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For user shares and group shares, creating a share should dispatch a UserMountAddedEvent for the recipient's share mount, and deleting it should dispatch a UserMountRemovedEvent. These tests only asks for this "at the latest when the recipient next loads their file system". Each case runs twice:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)