Repository navigation
feat(federation): ignore remote contacts - #65224
ArtificialOwl wants to merge 1 commit into
Conversation
It was not to share contacts, but to share users between the systems, and we do this by synchronizing the system address book
User contacts are not the same as "system contacts" although they are represented as an address book
In general, i agree that the token exchange should be separated from the any sync but at the moment the "system user sync" is what initiates the initial token exchange. That said implementing this means that users will not be able to search for users on other systems to share with, essentially breaking federate user search |
1268804 to
392c335
Compare
This is the main purpose, the federated user search will be done using OCM invite system. A bigger improvement would be to have a list of options on the Admin Settings / Sharing / Trusted Servers to enable/disable feature related to Trusted Servers. |
Has this been implemented? |
It should be since 34, via the contacts app. |
|
As said, some people just want to enjoy the other features requiring trusted servers without providing extra sharing contacts to their users. Currently, the only known/documented solution to avoid this behavior is to remove |
392c335 to
b5f42b6
Compare
The contacts app is not the only place we search for users, we do it in calendar and contacts integration also. So if you don'/t have the contacts app installed how do you search for federated users? At the moment all this information comes from the system address book. A proper solution would be to block users from sharing contacts but let the system address book sync so that users can still find other users |
Exactly, this is for setup where you do not want to search for federated users from the trusted instances |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
b5f42b6 to
e570484
Compare
On some setup, the sync of all remote contacts is not something wanted
This patch ignore the list of remote contacts.
It does not limit your instance to send your local contact to remote trusted server, but will maks your instance not storing the incoming list from others trusted servers.