Skip to content

feat(db): add smaller DBAL types when supported by database - #65308

Open
Altahrim wants to merge 1 commit into
masterfrom
feat/smaller_mysql_types
Open

Altahrim wants to merge 1 commit into
masterfrom
feat/smaller_mysql_types

Conversation

@Altahrim

@Altahrim Altahrim commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Introduce smaller int/datetime fields for databases that supports it

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Altahrim Altahrim added this to the Nextcloud 36 milestone Oct 8, 2026
@Altahrim Altahrim self-assigned this Oct 8, 2026
@Altahrim Altahrim added 2. developing Work in progress php Pull requests that update Php code feature: database Database related DB labels Oct 8, 2026
@Altahrim
Altahrim force-pushed the feat/smaller_mysql_types branch 4 times, most recently from 026144c to 1b09b6c Compare October 8, 2026 13:27
@Altahrim Altahrim removed the 2. developing Work in progress label Oct 8, 2026
@Altahrim
Altahrim marked this pull request as ready for review October 8, 2026 14:57
@Altahrim
Altahrim requested a review from a team as a code owner October 8, 2026 14:57
@Altahrim
Altahrim requested review from leftybournes, provokateurin, salmart-dev and sorbaugh and removed request for a team October 8, 2026 14:57
@Altahrim Altahrim added the 3. to review Waiting for reviews label Oct 8, 2026
@artonge
artonge requested review from CarlSchwan and come-nc and removed request for leftybournes, provokateurin, salmart-dev and sorbaugh October 8, 2026 15:04
Comment thread lib/public/DB/Types.php Outdated
*
* @since 36.0.0
*/
public const TINYINT = 'tinyint';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ihmo we should deprecate this whole class and not add more stuff

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? You think we should rely on DBAL types instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed edit to this file and relied on ColumnType instead

@Altahrim
Altahrim force-pushed the feat/smaller_mysql_types branch 2 times, most recently from 5e6561d to 1ef2e50 Compare October 19, 2026 14:46
@Altahrim
Altahrim requested a review from CarlSchwan October 19, 2026 15:49
@Altahrim
Altahrim force-pushed the feat/smaller_mysql_types branch 3 times, most recently from 306a9f1 to ad13627 Compare October 23, 2026 09:39
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrim force-pushed the feat/smaller_mysql_types branch from ad13627 to 0bbc616 Compare October 23, 2026 09:43
@Altahrim
Altahrim added this pull request to stack #65807 October 23, 2026 10:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: database Database related DB php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants