Repository navigation
Conversation
hefftich
force-pushed
the
feat/team-activity-resource-provider
branch
from
October 9, 2026 21:25
38078ea to
d2fd2f3
Compare
This was referenced Oct 9, 2026
hefftich
changed the title
5 of 8 tasks
hefftich
force-pushed
the
feat/team-activity-resource-provider
branch
2 times, most recently
from
October 12, 2026 11:15
114e38a to
77bba9d
Compare
hefftich
added
3. to review
hefftich
marked this pull request as ready for review
October 12, 2026 13:06
hefftich
requested review from
icewind1991,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
October 12, 2026 13:06
CarlSchwan
reviewed
Oct 14, 2026
| * | ||
| * @since 36.0.0 | ||
| */ | ||
| class TeamActivityScope { |
Member
There was a problem hiding this comment.
Suggested change
| class TeamActivityScope { | |
| final readonly class TeamActivityScope { |
Comment on lines
+24
to
+31
| if ($this->objectType === '') { | ||
| throw new \InvalidArgumentException('Activity object type must not be empty'); | ||
| } | ||
| foreach ($this->objectIds as $objectId) { | ||
| if (!is_int($objectId) || $objectId <= 0) { | ||
| throw new \InvalidArgumentException('Activity object IDs must be positive'); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if ($this->objectType === '') { | |
| throw new \InvalidArgumentException('Activity object type must not be empty'); | |
| } | |
| foreach ($this->objectIds as $objectId) { | |
| if (!is_int($objectId) || $objectId <= 0) { | |
| throw new \InvalidArgumentException('Activity object IDs must be positive'); | |
| } | |
| } |
| */ | ||
| class TeamActivityScope { | ||
| /** | ||
| * @param list<int> $objectIds |
Member
There was a problem hiding this comment.
Suggested change
| * @param list<int> $objectIds | |
| * @param list<positive-int> $objectIds | |
| * @param non-empty-string $objectType |
1 task done
hefftich
force-pushed
the
feat/team-activity-resource-provider
branch
from
October 14, 2026 14:34
77bba9d to
1c04c3f
Compare
…le id Introduce ITeamActivityResourceProvider as an optional capability for ITeamResourceProvider implementations to resolve their Team resources into Activity scopes, backed by the new TeamActivityScope value object. Also expose the filecache root id on TeamFolder so Activity providers can reference team folder contents. Signed-off-by: Stefan Lender <Stefan.Lender@dataport.de> Assisted-by: Copilot:gpt-6.1-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hefftich
force-pushed
the
feat/team-activity-resource-provider
branch
from
October 14, 2026 14:39
1c04c3f to
cb2784c
Compare
Contributor
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le id
Resolves:
Show activity of team in Teams app circles#2692
Relates:
Expose group folder activity scopes groupfolders#5148
Add activity and resource integration circles#3030
Add Team activity stream activity#3024
Add Deck resources to Team Activity deck#8516
Summary
Introduce
ITeamActivityResourceProvideras an optional capability forITeamResourceProviderimplementations to resolve Team resources into Activity scopes, backed by the newTeamActivityScopevalue object.The Activity app can use these scopes to include activity from Team-linked resources while each provider resolves only objects visible to the requesting user. Providers that do not support Activity require no changes.
Expose the filecache root ID on
TeamFolderso filesystem-backed providers can resolve the contents of Team folders into Activity scopes.Consumers
The initial consumers are:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
claude-sonnet-4.5