Repository navigation
[stable34] fix(user_ldap): remove leftover debug log in getUserFromCustomAttribute - #65712
Merged
Merged
Conversation
getUserFromCustomAttribute() logged the plain LDAP search filter at error level on every call. With user_saml's user_id_ldap_mapping this runs on every SAML login and writes an "error" entry containing only the filter (and thus the user's attribute value, e.g. a UPN/email), although the lookup succeeded. The ambiguous case (multiple matches) is still logged as before. Signed-off-by: TKDG2000 <324890600+TKDG2000@users.noreply.github.com>
CarlSchwan
approved these changes
Oct 20, 2026
CarlSchwan
approved these changes
Oct 20, 2026
joshtrichards
approved these changes
Oct 20, 2026
joshtrichards
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #65452