Repository navigation
fix(files): skip quota check when opening files for reading - #65769
Open
cristianscheid wants to merge 1 commit into
Open
cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
cristianscheid
requested review from
Altahrim,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
October 21, 2026 22:26
6 of 9 tasks
cristianscheid
force-pushed
the
fix/noid/quota-allow-reads
branch
from
October 22, 2026 11:40
1b3f2f9 to
a541a5f
Compare
susnux
approved these changes
Oct 22, 2026
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
joshtrichards
approved these changes
Oct 22, 2026
joshtrichards
left a comment
joshtrichards
left a comment
Member
There was a problem hiding this comment.
Makes sense.
Though could use some unit test coverage.
skjnldsv
reviewed
Oct 23, 2026
skjnldsv
approved these changes
Oct 23, 2026
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Slight request for the next dev looking at this code, otherwise good
cristianscheid
force-pushed
the
fix/noid/quota-allow-reads
branch
from
October 23, 2026 13:31
a541a5f to
9165236
Compare
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/noid/quota-allow-reads
branch
from
October 23, 2026 13:38
9165236 to
9238343
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip quota/free space check when opening files for reading, since reads don't consume any space.
Checklist
3. to review, feature component)stable32)AI (if applicable)