Repository navigation
Conversation
…activity Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Mario Alfonso Pym Mejía <pymm@hitss.com>
MarioPym
force-pushed
the
fix/link-remote-share-received-activity
branch
from
October 23, 2026 06:39
95d4950 to
a6390bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a federated share is received, the "You received a new remote share … from …" activity is published without a link, so clicking it in the activity stream does nothing. The other remote share activities of the same provider (accepted, declined) already set a link.
This adds a link to the Files view where the user can find the share:
/apps/files/pendingshares) when the share waits to be accepted./apps/files/sharingin) when it is auto-accepted from a trusted server.The link is set for user shares and for every member of a group share. The auto-accept condition is now computed once and reused in both branches.
How to test
GET /ocs/v2.php/apps/activity/api/v2/activity/all:linkand is not clickable.linkishttps://your-server/index.php/apps/files/pendingsharesand opens the Pending shares view./apps/files/sharingin.Unit tests:
apps/federatedfilesharing/tests/OCM/CloudFederationProviderFilesTest.php(pending user share, group share with one event per member, auto-accepted share).Checklist
3. to review, feature component)stable32)AI (if applicable)