Skip to content

fix(files): file cannot be deleted from Recent and Search views #65811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShGKme wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −22
Open

fix(files): file cannot be deleted from Recent and Search views #65811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27aed37
build(deps): bump @nextcloud/files from 4.1.0 to 4.1.1
ShGKme Oct 23, 2026
ad03caf
fix(files): file cannot be deleted from Recent and Search views
ShGKme Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions apps/files/src/services/Recent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ export async function getContents(path = '/', options?: { signal: AbortSignal })
}) as ResponseDataDetailed<SearchResult>

const contents = contentsResponse.data.results
.map((stat) => {
// The search endpoint already includes the dav remote URL so we must not include it in the source
stat.filename = stat.filename.replace('/remote.php/dav', '')
return resultToNode(stat)
})
.map((stat) => resultToNode(stat))
.filter(filterHidden)

return {
Expand Down
5 changes: 2 additions & 3 deletions apps/files/src/services/WebDavSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import type { INode } from '@nextcloud/files'
import type { ResponseDataDetailed, SearchResult } from 'webdav'

import { getCurrentUser } from '@nextcloud/auth'
import { defaultRootPath, getDavNameSpaces, getDavProperties, resultToNode } from '@nextcloud/files/dav'
import { getBaseUrl } from '@nextcloud/router'
import { getDavNameSpaces, getDavProperties, resultToNode } from '@nextcloud/files/dav'
import escapeHTML from 'escape-html'
import { logger } from '../utils/logger.ts'
import { client } from './WebdavClient.ts'
Expand Down Expand Up @@ -80,5 +79,5 @@ export async function searchNodes(query: string, { dir, signal }: SearchNodesOpt
}

// otherwise return the result mapped to Nextcloud nodes
return data.results.map((result) => resultToNode(result, defaultRootPath, getBaseUrl()))
return data.results.map((result) => resultToNode(result))
}
12 changes: 6 additions & 6 deletions build/frontend-legacy/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/frontend-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@nextcloud/capabilities": "^1.2.1",
"@nextcloud/dialogs": "^7.5.0",
"@nextcloud/event-bus": "^3.3.3",
"@nextcloud/files": "^4.1.0",
"@nextcloud/files": "^4.1.1",
"@nextcloud/initial-state": "^3.0.0",
"@nextcloud/l10n": "^3.4.1",
"@nextcloud/logger": "^3.0.3",
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@nextcloud/capabilities": "^1.2.1",
"@nextcloud/dialogs": "^7.5.0",
"@nextcloud/event-bus": "^3.3.3",
"@nextcloud/files": "^4.1.0",
"@nextcloud/files": "^4.1.1",
"@nextcloud/initial-state": "^3.0.0",
"@nextcloud/l10n": "^3.4.1",
"@nextcloud/logger": "^3.0.3",
Expand Down
Loading