Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Mario Alfonso Pym Mejía <pymm@hitss.com>
MarioPym
requested review from
Altahrim,
come-nc,
provokateurin and
salmart-dev
and removed request for
a team
October 23, 2026 16:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharesPluginbuilds theoc:share-typesproperty witharray_unique(), which keeps the original keys. When a node has more than one share of the same type (e.g. two user shares and a link),ShareTypeList::getShareTypes()returns[0 => 0, 2 => 3]instead of[0, 3].The XML output is the same, because the serializer only iterates the values. But the property is not a list anymore: any code that reads
getShareTypes()and encodes it as JSON gets an object ({"0":0,"2":3}) instead of an array ([0,3]).This wraps the result in
array_values()and documentsShareTypeListaslist<int>, so psalm can catch it in the future.How to test
getShareTypes()of theoc:share-typesproperty for that folder (the XML response does not show the keys):[0 => 0, 2 => 3](as JSON:{"0":0,"2":3}).[0, 3](as JSON:[0,3]).<oc:share-types>) does not change.Unit test:
testGetPropertiesReturnsListWithRepeatedShareTypesinapps/dav/tests/unit/Connector/Sabre/SharesPluginTest.php. The existing data provider never repeats a share type, so this case was not covered.Checklist
3. to review, feature component)stable32)AI (if applicable)