Repository navigation
feat(session): allow apps to renew the session id while keeping the login's token - #65817
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
…ogin's token Add ISessionIdRenewer. It gives the current session a new id, e.g. after the user proved their identity once more in this session. Unlike ISession::regenerateId() with $updateToken, the auth token is not replaced by a new one: the same token row, with its id, name and stored password, is moved to the new session id. Anything that refers to the token by its id, such as the pending second-factor marker or an app's own records, stays valid. A remember-me cookie that points to the old session id follows the new one, and the old id no longer finds the token, also not from the token cache. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small core change used by the
intrusion_detectionapp, alongside #65735–#65741. It can be reviewed and merged on its own: a new publicOCP\Session\ISessionIdRenewergives the current session a new id while keeping the same auth token row.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an
Assisted-bytrailer.🤖 Generated with Claude Code