Skip to content

fix(files): upload files with empty mime type - #65819

Open
bulungasdeveloper wants to merge 1 commit into
nextcloud:masterfrom
bulungasdeveloper:fix-drop-mime-by-extension
Open

bulungasdeveloper wants to merge 1 commit into
nextcloud:masterfrom
bulungasdeveloper:fix-drop-mime-by-extension

Conversation

@bulungasdeveloper

Copy link
Copy Markdown

Summary

The drop handler discarded files whose MIME type arrives empty from the browser, silently skipping them from the upload queue. Keep files with an unknown type and let the server detect it on upload (content sniffing + extension map). Directories are still skipped with a warning.

How to test

  1. In Files, drag & drop a file with an unknown extension over the file list.
  2. The file appears in the upload queue and is uploaded.
  3. A directory drop is still ignored with a warning.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests are included
  • Documentation not required
  • Backports requested where applicable

AI

  • The content of this PR was partly generated using AI

The drop handler discarded files whose MIME type arrives empty
from the browser (common in Chromium for unknown extensions),
silently skipping them from the upload queue. Keep files with an
unknown type and let the server detect it on upload (content
sniffing + extension map). Directories are still skipped with a
warning.

Assisted-by: opencode:MiMo-V2.6-Flash
Signed-off-by: Braux Martinez <martinezjb@hitss.com>
@bulungasdeveloper

Copy link
Copy Markdown
Author

Hi, the check-ai-trailers job fails on Label PR as AI assisted because the workflow cannot apply labels to a fork PR. The PR already has the AI assisted label and the commit includes Assisted-by: opencode:MiMo-V2.6-Flash and DCO sign-off. The 3. to review label has been added to allow the Playwright gate to skip correctly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant