Repository navigation
[stable34] fix(ci): clone vendored test apps from the matching stable branch - #65874
Merged
AndyScherzinger merged 1 commit intoOct 24, 2026
Merged
Conversation
The Playwright migration dropped the BRANCH env the Cypress workflow set, so @nextcloud/e2e-test-server fell back to 'master' and cloned nextcloud/viewer from its default branch. That branch is empty since the viewer moved to the @nextcloud/viewer library for 36+, so stable branches ran without a viewer and the "openfile" router-query tests failed deterministically. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> (cherry picked from commit 86b11ca)
AndyScherzinger
added
bug
3. to review
This was referenced Oct 24, 2026
AndyScherzinger
deleted the
fix/stable34/playwright-vendored-app-branch
branch
October 24, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playwright shard 5/8 fails deterministically on
stable34(e.g. #65865): the two"openfile"tests intests/playwright/e2e/files/router-query.spec.tsnever see the viewer dialog.Cause: the Cypress → Playwright migration (31abfbd) dropped the workflow-level
BRANCH: ${{ github.base_ref || github.ref_name }}env the Cypress workflow set. Without it@nextcloud/e2e-test-serverfalls back tomaster(├─ Using branch 'master'in the job log) and clonesnextcloud/viewerfrom its default branch without--branch. That branch is empty since the viewer moved to the@nextcloud/viewerlibrary for 36+, so the stable test server runs without a viewer.Fix: restore the
BRANCHenv, so vendored apps are cloned from the matchingstable34branch.masteris not affected, it does not clone the viewer.TODO
Checklist
3. to review, feature component)stable32)