Repository navigation
fix: remove visible description above recipient input in email share dialog - #75
Merged
memurats merged 1 commit intoOct 23, 2026
Conversation
…dialog The recipient field in the "Send link via E-Mail" dialog rendered the untranslated text "Share with users, groups or email addresses" as a visible label above the input, since NcSelect's inputLabel prop renders a <label> element. - Pass the text via aria-label-combobox instead, so the field keeps an accessible name for screen readers without showing a visible label - Drop the now unused label[for="sharing-search-input"] style rule - Add the German translation for the accessible name to de and de_DE
memurats
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recipient field in the "Send link via E-Mail" dialog rendered the untranslated text "Share with users, groups or email addresses" as a visible label above the input, since NcSelect's inputLabel prop renders a element.