Skip to content

Update to topic phyloflash - #12577

Open
LouisLeNezet wants to merge 26 commits into
nf-core:masterfrom
LouisLeNezet:phyloflash
Open

Update to topic phyloflash#12577
LouisLeNezet wants to merge 26 commits into
nf-core:masterfrom
LouisLeNezet:phyloflash

Conversation

@LouisLeNezet

Copy link
Copy Markdown
Contributor

PR checklist

Closes #12552

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this Aug 4, 2026
Comment thread modules/nf-core/phyloflash/environment.yml Outdated
@LouisLeNezet
LouisLeNezet requested review from a team as code owners August 6, 2026 08:33
@LouisLeNezet
LouisLeNezet marked this pull request as draft August 7, 2026 13:17
@LouisLeNezet
LouisLeNezet marked this pull request as ready for review September 3, 2026 10:04

@mahesh-panchal mahesh-panchal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good, but the action change should be it's own PR with description of what it's doing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate this into another PR so we have a description of what this is intended to fix please?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do so !

Comment thread .github/actions/nf-test-action/action.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to topic phyloflash

2 participants