Remove ext.use_gpu remnants (superseded by task.accelerator) - #4445
Open
mahesh-panchal wants to merge 4 commits into
Open
Remove ext.use_gpu remnants (superseded by task.accelerator)#4445mahesh-panchal wants to merge 4 commits into
mahesh-panchal wants to merge 4 commits into
Conversation
The accelerator directive now fully covers GPU scheduling, making the ext.use_gpu flag unnecessary.
ext.use_gpu is superseded by task.accelerator, so modules using it should now fail the ext key lint check like any other unrecognized key.
The description referenced a nonexistent use_gpu parameter instead of the process_gpu label and accelerator directive the feature generates.
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No dev-version bump PR has run since the 4.1.0 release, so the changelog automation's expected running section didn't exist yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext.use_gpuis superseded by Nextflow's nativetask.acceleratordirective. This removes the remainingext.use_gpureferences:ext.use_gpuline from theprocess_gpulabel in the pipeline template'sbase.configext.use_gpufrom the module linter's permitted ext keyscreatewizard'sgpufeature help text to describeacceleratorinstead of a nonexistentuse_gpuparameter