feat: add lexists template function - #762
Open
JamBalaya56562 wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a new lexists template function to check path existence without following symlinks, addressing the dangling-symlink behavior requested in #187.
Changes:
- Add
internal/utils.PathLExists, implemented viaos.Lstat(symlink-aware existence check). - Register
lexistsin the templateFuncMapalongsideexists. - Document
lexistsin the README function list and add unit test coverage for normal/missing/dangling-symlink cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents the new lexists template function behavior and usage. |
| internal/utils/utils.go | Adds PathLExists helper using os.Lstat for non-following symlink existence checks. |
| internal/utils/utils_test.go | Adds TestPathLExists, including the distinguishing dangling-symlink behavior. |
| internal/template/template.go | Registers lexists in the template function map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Replace the hard-coded /wrong/path with a path under t.TempDir() that is never created, so the missing-path and dangling-symlink assertions do not depend on a path outside the test's control. Unit tests also run on windows-latest, where /wrong/path resolves against the current drive. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
lexiststemplate function — theos.Lstatcounterpart of the existingexists.existsis backed byos.Stat, which follows symlinks, so a symlink whose target is missing (a dangling link) reports as non-existent.lexistsusesos.Lstat, which stats the link itself without following it, so it returnstruefor the symlink even when its target is unavailable. This is the behaviour requested in #187 (check for existence without traversing the symlink).Change
internal/utils: addPathLExists, mirroringPathExistsbut usingos.Lstatinstead ofos.Stat(samefs.ErrNotExisthandling).internal/template: register it in the templateFuncMapaslexists, next toexists.README.md: documentlexistsalongsideexists.Tests
TestPathLExistscovers an existing file (true), a missing path (false), and — the distinguishing case — a dangling symlink, assertinglexistsreturnstruewhileexistsreturnsfalse. The symlink portion is skipped where symlink creation isn't permitted (e.g. Windows without the privilege).Fixes #187
🤖 Generated with Claude Code