NGF: Add document for upstream http2 - #2021
Conversation
|
This is a shorter guide which is technically covering a Kubernetes concept (Service's appProtocol), however I couldn't find a suitable document to include this information in. So I decided to write a standalone document for it. |
|
hi @bjee19 can you please resolve the suggestions and re-request reviews in slack? |
4d1d001 to
87185c0
Compare
|
@bjee19 This guide feels excessive for this use case. I feel like this could be as simple as saying what the protocol field does, and then end it there. Having a whole setup just to verify a single directive in the nginx config is too much in my opinion. |
|
@sjberman, I am definitely down to strip down this guide into what you suggested. However, would that entail just having it be a section in a larger document? I worry, that it would just get overshadowed if so. However, on the other end, having a separate document with such a small guide feels foreign. |
|
@bjee19 I'm not opposed this being its own, small guide. |
|
@salonichf5, do you have any thoughts or concerns about this guide just being a few small lines with no large setup? And it being its own separate guide? |
I am okay with it as well |
|
Updated by removing the example, let me know if you think the other sections aren't needed, however I see some value in them. |
Proposed changes
Add document on supporting http2 to upstream through the appProtocol field on a Service.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩