Skip to content

NGF: Add document for upstream http2 - #2021

Merged
bjee19 merged 7 commits into
nginx:ngf-release-2.7from
bjee19:ngf/http2-appProtocol
Jul 21, 2026
Merged

NGF: Add document for upstream http2#2021
bjee19 merged 7 commits into
nginx:ngf-release-2.7from
bjee19:ngf/http2-appProtocol

Conversation

@bjee19

@bjee19 bjee19 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Add document on supporting http2 to upstream through the appProtocol field on a Service.

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@bjee19
bjee19 requested a review from a team as a code owner June 3, 2026 05:49
@github-actions github-actions Bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels Jun 3, 2026
@bjee19

bjee19 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

This is a shorter guide which is technically covering a Kubernetes concept (Service's appProtocol), however I couldn't find a suitable document to include this information in. So I decided to write a standalone document for it.

@bjee19
bjee19 requested a review from a team June 3, 2026 05:49
Comment thread content/ngf/traffic-management/upstream-http2-appprotocol.md Outdated
Comment thread content/ngf/traffic-management/upstream-http2-appprotocol.md Outdated
Comment thread content/ngf/traffic-management/upstream-http2-appprotocol.md Outdated
Comment thread content/ngf/reference/permissions.md Outdated
@bjee19
bjee19 requested a review from a team June 16, 2026 16:34
@JTorreG

JTorreG commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

hi @bjee19 can you please resolve the suggestions and re-request reviews in slack?

Comment thread content/ngf/reference/permissions.md Outdated
Comment thread content/ngf/traffic-management/upstream-http2-appprotocol.md Outdated
Comment thread content/ngf/traffic-management/upstream-http2-appprotocol.md Outdated
@bjee19
bjee19 force-pushed the ngf/http2-appProtocol branch from 4d1d001 to 87185c0 Compare June 30, 2026 18:34
@bjee19
bjee19 requested a review from salonichf5 June 30, 2026 19:24
@sjberman

Copy link
Copy Markdown
Contributor

@bjee19 This guide feels excessive for this use case. I feel like this could be as simple as saying what the protocol field does, and then end it there. Having a whole setup just to verify a single directive in the nginx config is too much in my opinion.

@bjee19

bjee19 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@sjberman, I am definitely down to strip down this guide into what you suggested. However, would that entail just having it be a section in a larger document? I worry, that it would just get overshadowed if so. However, on the other end, having a separate document with such a small guide feels foreign.

@sjberman

Copy link
Copy Markdown
Contributor

@bjee19 I'm not opposed this being its own, small guide.

@bjee19

bjee19 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@salonichf5, do you have any thoughts or concerns about this guide just being a few small lines with no large setup? And it being its own separate guide?

@salonichf5

Copy link
Copy Markdown
Contributor

@salonichf5, do you have any thoughts or concerns about this guide just being a few small lines with no large setup? And it being its own separate guide?

I am okay with it as well

@bjee19

bjee19 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Updated by removing the example, let me know if you think the other sections aren't needed, however I see some value in them.

@bjee19
bjee19 merged commit f284ffb into nginx:ngf-release-2.7 Jul 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants