Repository navigation
Conversation
Owner
Author
Maker-Checker Review: F010 (Push-to-talk, on-device STT → chat)1. Acceptance Criteria Verification
2. Evaluation Scores
3. DecisionAPPROVE. Ready for squash merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements F010: Push-to-talk, on-device STT → chat, the first feature in Phase 04 (Voice — thin).
Changes Included:
@shellmind/mobile/src/voice):types.ts: DefinesISpeechToTextProviderinterface with contract:isAvailable(): Promise<boolean>requestPermission(): Promise<"granted" | "denied" | "undetermined">startRecording(onInterimResult?: (text: string) => void): Promise<void>stopRecording(): Promise<string>cancelRecording(): Promise<void>isRecording(): booleanmock.ts:MockSpeechToTextProviderproviding deterministic audio simulation, configurable fixture text, interim transcript streaming (word-by-word with delay), cancellation, and error/permission testing support.native.ts:NativeSpeechToTextProviderintegrating with native speech recognition (@react-native-voice/voice/ Web Speech API) and falling back gracefully if native recognition is unavailable.registry.ts: Provider registration withgetSpeechToTextProvider(),setSpeechToTextProvider(), andresetSpeechToTextProvider().packages/mobile/src/voice/index.tsandpackages/mobile/src/index.ts.@shellmind/mobile/src/components/ChatScreen.tsx):testID="mic-button").testID="recording-indicator") with pulse label and interim transcript preview.testID="voice-cancel-button").testID="chat-input-field"so text is clearly visible and user-editable before sending.testID="voice-error-banner") and dismissal button (testID="voice-error-dismiss"), falling back safely to keyboard typing.packages/mobile/src/mobile.test.tscovering STT lifecycle, interim streaming, recording cancellation, permission denial, native fallback, registry overrides, and ChatScreen voice props.dependency-cruiser(75 modules, 220 dependencies cruised, 0 violations)..maestro/voice_stt_flow.yaml..harness/evidence/F010/.