Repository navigation
Conversation
Owner
Author
Maker-Checker Review: F011 (On-device TTS spoken replies)1. Acceptance Criteria Verification
2. Evaluation Scores
3. DecisionAPPROVE. Ready for squash merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements F011: On-device TTS spoken replies (toggle), completing Phase 04 (Voice — thin) and bringing the entire ShellMind roadmap to 100% completion (12 / 12 features complete)!
Changes Included:
@shellmind/mobile/src/voice):tts-types.ts: DefinesITextToSpeechProviderinterface andTTSOptions(rate?,pitch?,language?, callbacks:onStart?,onDone?,onError?):isAvailable(): Promise<boolean>speak(text: string, options?: TTSOptions): Promise<void>stop(): Promise<void>isSpeaking(): booleansummary.ts: ImplementsextractSpokenSummary(text, maxChars = 300):. ! ?within maxChars limit) and word boundary fallbacks, strictly guaranteeing length<= maxChars.mock-tts.ts:MockTextToSpeechProviderproviding test simulation with speech history tracking, autocomplete delays, and error/availability injection.native-tts.ts:NativeTextToSpeechProvidersafely bridging iOSAVSpeechSynthesizer/ Expo Speech / browser speech synthesis with safe non-throwing fallbacks.registry.ts: Provider registry accessors (getTextToSpeechProvider,setTextToSpeechProvider,resetTextToSpeechProvider).packages/mobile/src/voice/index.tsandpackages/mobile/src/index.ts.@shellmind/mobile/src/components/ChatScreen.tsx):testID="tts-toggle") with visual icons and status text (🔊 Voice On/🔇 Voice Off).testID="speaking-indicator") with a pulse dot and interrupt/mute button (testID="tts-stop-button").event.type === "done"), extracts the concise summary and callsspeak().packages/mobile/src/mobile.test.tsverifying provider lifecycle, stop/interruption, autocomplete, summary cleaning, length capping, rapid turn handling, and ChatScreen options.dependency-cruiser(79 modules, 229 dependencies cruised, 0 violations)..maestro/voice_tts_flow.yaml..harness/evidence/F011/.