Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F005: Mobile Terminal UI (emulator, accessory keys, scrollback, history)
Summary
Implements Phase 02 feature F005 (
Mobile terminal UI):TerminalBuffer) vs xterm.js in WebView, choosing Native RN ANSI buffer for zero input latency, native accessory key integration, and pure-TypeScript unit-testability without native webview binary overhead.TerminalBuffer(src/terminal/buffer.ts) handling ANSI 16/256/truecolor parsing, SGR styles, carriage returns (\r), backspaces (\b), line clear sequences, OSC sequence stripping, and a 2000-line scrollback buffer.openTerminal,sendTerminalInput,resizeTerminal,onTerminalData,onTerminalExit) toAgentClient.AccessoryBar.tsx: Mobile keyboard accessory row (Ctrl,Esc,Tab,↑,↓,←,→,|,/,-,~,Hist) with activeCtrlcombo modifier handling.HistoryModal.tsx: Command history list modal with tap-to-rerun.TerminalScreen.tsx: Monospace terminal display, autoscrolling on output, responsive layout resize measurement, and offline banner.StatusScreen.tsx: Added quick switch button to terminal.App.tsx: Tab navigation between Terminal (default when paired) and Status views.src/terminal/buffer.test.ts(8/8 passing).src/mobile.test.tsdriving live WebSocket connection and streaming lifecycle..maestro/terminal_flow.yaml.Verification
pnpm typecheck: 0 errors.pnpm lint: 0 errors, 0 warnings.pnpm test: 49/49 tests passing across all packages (18 protocol, 10 agent, 21 mobile).scripts/check-architecture.sh: 0 dependency violations (pure core and layer boundaries clean).scripts/init.sh: clean baseline verified.Checklist
DECISIONS.mddependency-cruiser.harness/evidence/F005/