Repository navigation
Conversation
nimat-dev
commented
Oct 8, 2026
nimat-dev
left a comment
Owner
Author
There was a problem hiding this comment.
Maker-Checker Review: F007 (Claude driver)
1. Acceptance Criteria Verification
- Protocol message schemas (
agent.prompt,agent.stream,agent.abort,project.list,project.set) defined and registered in@shellmind/protocol. - Pure core interfaces
IClaudeDriverandIProjectManagerin@shellmind/agent/src/core/have 0 I/O imports. -
LocalClaudeDriverspawnsclaude -p --output-format stream-json --verbosewith incremental parsing and child lifecycle management. - Cwd switching supported via
NodeProjectManager. - Clean cancellation via
agent.abortand disconnect cleanup (no orphan processes). - Mobile
AgentClienthandles prompt submission, stream listeners, abort, and project switching. - Clean architecture verified via
dependency-cruiser(0 violations). - 77/77 tests passing across monorepo packages.
2. Evaluation Scores
- Acceptance: 5/5
- Correctness: 5/5
- Boundaries: 5/5
- Modularity: 5/5
- Evidence: 5/5
- Average: 5.0 (PASS)
3. Decision
APPROVE. Ready for squash merge to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements F007: Claude driver (spawn
claude -pstream-json, parse -> protocol, switchable project cwd, abort), launching Phase 03 (AI — Claude Code bridge).Changes Included:
@shellmind/protocol):agent.prompt: Client prompt payload ({ prompt: string; cwd?: string }).agent.stream: Streaming events envelope (assistant_text,tool_use,tool_result,rate_limit,done,aborted,error).agent.abort: Clean turn cancellation.project.list&project.list.resp: Project directory discovery.project.set&project.set.resp: Switchable project working directory.KnownMessageunion andMessageRegistry.@shellmind/agent):IClaudeDriver,ClaudeTurnOptionsinsrc/core/claude.ts.IProjectManager,ProjectInfoinsrc/core/project.ts.@shellmind/agent):ClaudeStreamParserinsrc/adapters/claude-driver/parser.ts: Incremental chunk buffering, parsing stream-json JSONL into typed stream events, with tolerance for non-JSON logs.LocalClaudeDriverinsrc/adapters/claude-driver/driver.ts: Spawnsclaude -p <prompt> --output-format stream-json --verbose, captures stdout/stderr, supports cancellation (SIGINT/SIGKILL), busy guard, and surfaces actionable errors (CLI_NOT_FOUND).NodeProjectManagerinsrc/adapters/project/node-project.ts: Absolute path verification and project directory listing.AgentDaemonand CLI with orphan process prevention on disconnect/shutdown.@shellmind/mobile):AgentClientmethods:sendAgentPrompt(),abortAgent(),onAgentStream(),requestProjectList(),setProject()..maestro/claude_stream_flow.yaml.dependency-cruiser(54 modules, 0 violations).