Repository navigation
Conversation
Shreyavemana
left a comment
Shreyavemana
left a comment
Collaborator
There was a problem hiding this comment.
I tested this PR locally. All five task-related test files passed. There are a couple of issue i found:
-
tools/list still advertises task_support='optional' for auto and modern, even though task support is disabled. Please fix this and add a regression test.
-
Full test suite fails: The PR has test collection errors related to the removed transport modules and build_ping_response. Additional failures also appeared when running the remaining tests, so the full suite needs to be rerun after the changes are addressed.
Lists of tests that failed:
- tests/test_mcp20_blueprint.py — missing nitrostack.transports.dispatch
- tests/test_mcp20_deprecated.py — missing nitrostack.transports.dispatch
- tests/test_mcp20_jsonrpc_wire.py — missing nitrostack.transports.dispatch
- tests/test_mcp20_stateless_http.py — cannot import build_ping_response from nitrostack.protocol.jsonrpc
After exclusion of these 4; 2 more tests failed
test_mcp20_test_modules_importable & test_supported_versions_per_era
… the legacy wire - tools/list no longer advertises execution.taskSupport or _meta.task_support on auto/modern (regression tests added, they fail without the fix) - restore the in-flight registry and cancel handling that the previous commit removed by accident (needed for concurrent calls that reuse a JSON-RPC id) - tests that exercise task augmentation now build their app with protocol_era="legacy"
Resolve the modify/delete conflicts by keeping the sidecar modules deleted, as this PR intends. develop's session-id rejection lived only in those modules.
…TP rules as xfail - remove tests that import or exercise StatelessIngressPipeline, IngressContext, StatelessTransportMiddleware and build_ping_response (the code is deleted) - the 21 HTTP tests that checked rules only the sidecar enforced are marked xfail(run=False) with a reason instead of being deleted, because the official /mcp app behaves differently (session-id rejection, Mcp-Method/Mcp-Name rules, modern initialize rejection). They need a keep-or-drop decision.
Resolve nitrostack/testing/__init__.py by keeping develop's create(protocol_era=None, transforms=None); the earlier protocol_era='auto' default is covered by it.
…en-tasks 2026 wire - task conformance tests (blueprint) build their app with protocol_era=legacy - tasks/* handlers are absent on auto/modern, so the tests now assert that instead of calling a handler that no longer exists - tasks/result and tasks/list are no longer listed as deprecated modern methods - the SEP-2243 method table has no tasks/* rows on the 2026 wire - tools_list_baseline.json: auto and modern no longer carry _meta.task_support
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25