Repository navigation
fix: unify HTTP factory and migrate tests to official MCP transport - #36
Open
jpsiddharth2008 wants to merge 7 commits into
Open
jpsiddharth2008 wants to merge 7 commits into
jpsiddharth2008 wants to merge 7 commits into
Conversation
Shreyavemana
left a comment
Collaborator
There was a problem hiding this comment.
I tested PR #36 locally.
- The issue verification tests pass (46 passed).
- However, the full test suite fails: four test files fail during collection because of removed modules/functions, and two additional tests fail after excluding them:
test_mcp20_blueprint.py— missingnitrostack.transports.dispatchtest_mcp20_deprecated.py— missingnitrostack.transports.dispatchtest_mcp20_jsonrpc_wire.py— missingnitrostack.transports.dispatchtest_mcp20_stateless_http.py— cannot importbuild_ping_response
(Additional failed test after removing the above ones)
test_mcp20_test_modules_importabletest_supported_versions_per_era
Please address the remaining test failures and rerun the full test suite.
4 tasks
Collaborator
|
Restore Access-Control-Expose-Headers, which is missing compared with develop. Make the source-scanning tests independent of the directory pytest runs from. Do the #22 request-context items or link a follow-up issue. Finally Merge it ahead of #34, #35 and #91 , since it already includes #34's commit. ~sent from claude-code |
jpsiddharth2008
force-pushed
the
feature/issue-23-http-factory
branch
from
October 28, 2026 13:06
71e47f1 to
90ddc61
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #23. Complete the HTTP factory migration after removal of the duplicate
JSON-RPC sidecar. Official MCP 2.x remains the sole owner of
/mcp.PR #34 is now merged. This branch has been rebased onto current
develop(
63ecd92); the old dependency commits do not need to be merged again.Changes
official MCP HTTP application, retaining parsing, protocol-contract, SSE,
response-header and identity coverage.
collection errors without compatibility shims or excluded modules.
remains enabled; auto/modern advertise false and reject resource subscriptions.
instances and stdio. Apply protocol policy through public MCP middleware.
dynamic browser parameter headers, health/slash handling and
/json/version.Post-rebase verification
MCP 2.2.0. Complete collection succeeds with 866 tests. Full suites use no
ignored files, deselections, skips or xfails:
git diff --checkpasses. The local results above use MCP 2.2.0.Hosted CI: all checks passed
GitHub Actions run 40693461293
passed on the rebased head
90ddc61, using MCP 2.3.0:Earlier hosted results for
71e47f1are historical; the run linked abovevalidates the new published head.
See
docs/pr36-review-verification.mdfor reproduction details and the rebaserecord. PR #37 remains stacked on this PR and should land afterward.