Repository navigation
[health] Async @health_check methods always report an error #63 - #89
Merged
manish-wekan merged 2 commits intoOct 27, 2026
Merged
manish-wekan merged 2 commits into
manish-wekan merged 2 commits into
Conversation
Shreyavemana
force-pushed
the
fix/async-health-checks
branch
from
October 25, 2026 14:29
b8b7324 to
3a96917
Compare
Shreyavemana
force-pushed
the
fix/async-health-checks
branch
from
October 25, 2026 16:34
3a96917 to
234b32a
Compare
AadarshM07
approved these changes
Oct 26, 2026
Collaborator
There was a problem hiding this comment.
Looks good to me, the changes seems to address what issue #63 demands. tests also passes.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #63.
Async
@health_checkmethods were failing when accessed throughhealth://statusbecauseHealthCheckRegistry.run_all()usedrun_until_complete()inside an already running event loop. This resulted in:and unawaited coroutine warnings.
Changes
HealthCheckRegistry.run_all()asynchronous.health_status_resourceto awaitHealthCheckRegistry.run_all().Tests
Added:
tests/test_health_async_checks.pyhealthy.RuntimeWarning: coroutine was never awaitedwarnings under-W error::RuntimeWarning.Updated:
tests/test_decorators_extra.pyrun_all()tests updated for the async implementation.Verification
health://status@health_checkmethods always report an error #63 satisfied