Repository navigation
Conversation
jpsiddharth2008
requested changes
Oct 28, 2026
jpsiddharth2008
left a comment
jpsiddharth2008
left a comment
Collaborator
There was a problem hiding this comment.
Please fix these issues on 5bcb5ba:
_visibility_session_key()reads attributes absent from real MCP sessions. Use the transport-validated session ID plus verified subject; test HTTP unlock/list/call across two sessions.search_toolsexposes hidden names and schemas through the unfiltered registry. Apply per-request visibility filtering and test search results.default_visibleshifts existing positional@toolarguments. Append it after existing parameters and add a compatibility test.
Resolve the develop conflict and rerun the full suite without exclusions. The current 895 passing tests miss these cases.
jpsiddharth2008
approved these changes
Oct 29, 2026
jpsiddharth2008
left a comment
jpsiddharth2008
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The three previous findings are resolved, and regression tests and CI pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds per-session dynamic tool visibility, including hidden defaults, ExecutionContext.enable_tools() / disable_tools(), and a TTL/LRU session store. Visibility is isolated by transport session ID and verified subject; hidden tools are omitted from tools/list and rejected by tools/call. Visibility changes notify the current session when the transport supports it.
Dynamic changes require a sessionful transport. In sessionless auto, changes warn and do nothing.
Tests:
892 passed; 3 failed
due to environment limitations: bdist_wheel is unavailable for the wheel packaging test, and two regex transform tests cannot start their worker process (PermissionError).
closes #65