Repository navigation
Codex/bounded format imports - #1
Merged
Merged
Conversation
Resolve defaultSampleType by integer value, retain exact uint64 function/location identities, and validate string-table/source-line indices. Copy location-specific frame metadata instead of mutating shared function definitions, preserving separate call-site lines. Add preferred/fallback metric, colliding low-word uint64 ID and source-line regressions. Update the reviewed pprof snapshot: per-location frames split correctly while aggregate weights remain unchanged. Both pprof suites pass (4 tests, 3 snapshots).
Recognize classic Android method traces v1-v3 before protobuf/text sniffing; scan binary records twice with explicit CPU/wall/dual clocks and no parsed-event array. Preserve method signatures, threads, source metadata and clipped observation windows; reject malformed or unsupported layouts. Read classic ZIP32 STORE/DEFLATE Java snapshots through bounded incremental UTF-8 lines into shared output builders. Validate catalogue/header agreement, paths, actual expansion, CRC and data descriptors. Enforce 32 MiB compressed, 512 entries, 16 MiB per entry and 64 MiB expanded total, with signature-only oversized File preflight and cancellation. Add independent synthetic fixtures, 12 Android regressions and 14 ZIP regressions; retain passing existing Java text tests. Document supported subsets and remaining model memory costs.
Use the existing generic worker importer for every recording of at least 1 MiB, independent of extension. Cover perf, folded stacks, pprof, JFR, Android and ZIP while retaining duration streaming and DOM/CSP fallbacks. Preserve progress cancellation metadata for yielding ZIP fallback, preflight oversized worker ZIP Files before full reads, and reject transferred-buffer fallback without ownership. Regress actual generic imports and snapshot roundtrips, cancellation, gzip reads, fallback and limits. Generic input/model and snapshot memory remain proportional to the recording.
Update in-app Help, README and packaged guides for classic Android traces and bounded Java snapshot ZIPs. Record worker fallback/model memory limits and pprof source identity semantics. Classify upstream jlfwong#40 and jlfwong#173 as implemented for the explicitly documented subsets; retain unsupported variants and keep large-trace OOM issues partial. Record 458 passing Jest tests, 307 snapshots, five Node tests, builds, browser checks and unchanged private PLC export hash. Document ARM64 runtime and real-device validation limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.