lookup: remove JSONStream - #1114
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2132 2132
Misses 81 81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This package fails in Steps to reproduceOn Ubuntu 24.04.4 LTS, Node.js 24.19.0 npm install -g npm@12.0.2
npm install -g citgm@10.0.2 --allow-scripts=yarn
citgm JSONStreamLogs$ citgm JSONStream
info: starting | JSONStream
info: lookup | JSONStream
info: lookup-found | JSONStream
info: JSONStream lookup-replace| https://github.com/dominictarr/JSONStream/archive/0593d4b4e6c63c6c0e2e68463538fd83bd1eb964.tar.gz
info: JSONStream npm: | Downloading project: https://github.com/dominictarr/JSONStream/archive/0593d4b4e6c63c6c0e2e68463538fd83bd1eb96
info: JSONStream npm: | Project downloaded 0593d4b4e6c63c6c0e2e68463538fd83bd1eb964.tar.gz
info: JSONStream npm: | npm install started
warn: JSONStream npm-install:| npm error code EALLOWGIT
warn: JSONStream npm-install:| npm error Fetching packages of type "git" have been disabled
warn: | npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df
warn: JSONStream npm-install:| npm error A complete log of this run can be found in: /tmp/720dcdf6/home/.npm/_logs/2026-08-04T14_49_01_252
error: failure | Install Failed
error: failing module(s) |
error: module name: | JSONStream
error: version: | 1.3.5
error: error: | Install Failed
error: error: | undefined
error: | npm error code EALLOWGIT
error: | npm error Fetching packages of type "git" have been disabled
error: | npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428
error: | npm error A complete log of this run can be found in: /tmp/720dcdf6/home/.npm/_logs/2026-08-04T14_49_01_252Z-d
error: done | The smoke test has failed.
info: duration | test duration: 6657msAlternative stepsgit clone https://github.com/dominictarr/JSONStream
cd JSONStream
npm installLogs$ git clone https://github.com/dominictarr/JSONStream
cd JSONStream
npm install
Cloning into 'JSONStream'...
remote: Enumerating objects: 769, done.
remote: Total 769 (delta 0), reused 0 (delta 0), pack-reused 769 (from 1)
Receiving objects: 100% (769/769), 251.24 KiB | 332.00 KiB/s, done.
Resolving deltas: 100% (462/462), done.
npm error code EALLOWGIT
npm error Fetching packages of type "git" have been disabled
npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"
npm error A complete log of this run can be found in: /home/mike/.npm/_logs/2026-08-04T14_50_21_985Z-debug-0.log |
|
imo we should still keep it in citgm, but set the npmrc to allow git deps for this one. |
Please share your concerns about the impact of removing the unsupported JSONStream from lib/lookup.json. This PR assumes that unsupported packages should be removed, since they wouldn't qualify to be added anymore. |
|
I think that regardless of support status, citgm must retain some package that has non-lowercase letters. I don't care ifi t's JSONStream or something else. |
npm does not allow new packages to be created with uppercase characters in their names. Do you know of any active npm package that does still have uppercase characters? I'm afraid though that |
JSONStream,leveldown&qetc. #1113Situation
JSONStream is deprecated and unsupported. It cannot therefore fulfil the Hard Requirements:
Change
Remove JSONStream from lib/lookup.json
Checklist
npm testpasseshere
cc: @dominictarr