Skip to content

lookup: remove q - #1123

Open
MikeMcC399 wants to merge 3 commits into
nodejs:mainfrom
MikeMcC399:remove/q
Open

lookup: remove q#1123
MikeMcC399 wants to merge 3 commits into
nodejs:mainfrom
MikeMcC399:remove/q

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

q is deprecated and unsupported. It cannot therefore fulfil the Hard Requirements:

The maintainers of the module remain responsive when there are problems

Item Status
npm package https://www.npmjs.com/package/q
npm status deprecated
last published 1.5.1 Oct 19, 2017
repo location https://github.com/kriskowal/q
repo status archived on Jan 22, 2025
lookup maintainer(s) kriskowal

npm Author message:

You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)

Node.js npm macos ubuntu windows
22.23.1 10.9.8 pass pass pass
24.19.0 11.17.0 pass pass pass
26.7.0 11.19.0 fail fail fail
26.7.0 12.0.2 - fail -

Change

Remove q from lib/lookup.json

Checklist
  • npm test passes
  • contribution guidelines followed
    here

cc: @kriskowal

@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.33%. Comparing base (1c00f12) to head (4eff8ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2132     2132           
  Misses         81       81           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 10, 2026 13:57
@MikeMcC399

Copy link
Copy Markdown
Contributor Author

Test failure appears to be flake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants